[v16.x] deps: V8: Add Power10 to the supported list and enable related features#38489
Closed
miladfarca wants to merge 2 commits intonodejs:v16.x-stagingfrom
miladfarca:p10-port
Closed
[v16.x] deps: V8: Add Power10 to the supported list and enable related features#38489miladfarca wants to merge 2 commits intonodejs:v16.x-stagingfrom miladfarca:p10-port
miladfarca wants to merge 2 commits intonodejs:v16.x-stagingfrom
miladfarca:p10-port
Conversation
github-actions
bot
added
build
Collaborator
Collaborator
Collaborator
Contributor
Author
|
@richardlau is |
Member
|
@miladfarca The test has been failing a lot recently on s390x: #38226 |
richardlau
approved these changes
May 1, 2021
Contributor
Author
|
Thanks for the link. Yes some other tests seem to be flaky too i.e |
Collaborator
Trott
approved these changes
May 1, 2021
Collaborator
targos
approved these changes
May 3, 2021
Collaborator
cjihrig
approved these changes
May 3, 2021
jasnell
approved these changes
May 3, 2021
gireeshpunathil
approved these changes
May 3, 2021
Contributor
|
Should this target |
Contributor
Author
AshCripps
approved these changes
May 4, 2021
jasnell
changed the title
Collaborator
Contributor
Author
|
@richardlau Would you please help with landing this as well? |
Collaborator
richardlau
approved these changes
May 14, 2021
richardlau
pushed a commit
that referenced
this pull request
May 14, 2021
Original commit message:
```
PPC: Add Power10 to the supported list and enable related features
This CL adds Power10 recognition to Linux, AIX as well as IBMi.
Enabled features include:
MODULO
FPR_GPR_MOV
SIMD
LWSYNC
ISELECT
VSX
Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
Reviewed-by: Clemens Backes <[email protected]>
Reviewed-by: Junliang Yan <[email protected]>
Reviewed-by: Vasili Skurydzin <[email protected]>
Commit-Queue: Milad Fa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#74279}
```
Refs: v8/v8@530080c
PR-URL: #38489
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Member
|
Landed in f31a611. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that enum values are slightly different from V8 upstream, i.e
PPC_POWER10instead ofkPPCPower10.We also have SIMD enabled upstream which will not be backported here.
Refs: v8/v8@530080c